Re: cvs: php-src(PHP_5_3) /ext/phar cgidebug phar.c phar.phar tar.c

On Sun, Jun 22, 2008 at 18:47, Steph Fox <steph@phparch.com> wrote: > > Hi Greg, Hannes, > >>> You'll be happy to hear that all other tests pass under 5_3 on my box :-) >> >> Not for me.. >> > <snip long list of failing tests /> >> >> Phar: tar-based phar corrupted [ext/phar/tests/tar/tar_001.phpt] >> Phar: tar-based phar corrupted 2 [ext/phar/tests/tar/tar_002.phpt] >> Phar: truncated tar [ext/phar/tests/tar/truncated.phpt] >> >> These are all failing here > > I reverted two short blocks of code (part of the phar_build() optimization) > for now. > > @Hannes: Felipe reports a 100% pass rate now, can you confirm please? Phar: mounted manifest directory test [ext/phar/tests/mounteddir.phpt] Phar::buildFromDirectory(), directory exists [ext/phar/tests/phar_buildfromdirectory4.phpt] Phar: Phar::extractTo() [ext/phar/tests/phar_extract.phpt] Phar: Phar::extractTo() - .phar safety [ext/phar/tests/phar_extract2.phpt] No idea which commit caused these failures, but the phar tests have never worked 100% for me. -Hannes