Re: Re: cvs: php-src(PHP_5_3) /ext/hash hash.c
| From: | Pierre Joye | Date: | Sat, 05 Jul 2008 07:54:56 +0000 |
| Subject: | Re: Re: cvs: php-src(PHP_5_3) /ext/hash hash.c | ||
| References: | 1 2 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-50802@lists.php.net to get a copy of this message | ||
On Sat, Jul 5, 2008 at 1:21 AM, Scott MacVicar
<scottmacvicar@ntlworld.com> wrote:
> This causes all the mhash tests to fail as it registers a 128 character
> constant since REGISTER_LONG_CONSTANT does sizeof(name) for the length.
>> - char name[len+1];
>> + char name[128];
All tests passed here (win and linux). But your new version is cleaner
as shorter and no useless memcpy, thanks :)
And it builds (win32 snapshots are back too, I fixed them yesterday,
between the compilation error and some script bug).
Cheers,
--
Pierre
http://blog.thepimp.net | http://www.libgd.org