Re: cvs: php4 /ext/odbc php_odbc.c
| From: | Sterling Hughes | Date: | Mon, 16 Apr 2001 15:16:59 +0000 |
| Subject: | Re: cvs: php4 /ext/odbc php_odbc.c | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-5136@lists.php.net to get a copy of this message | ||
On Tue, 17 Apr 2001, Dan Kalowsky wrote:
> kalowsky Mon Apr 16 19:02:36 2001 EDT
>
> Modified files:
> /php4/ext/odbc php_odbc.c
> Log:
> This change seems to fix bugs 7158, 7807, 8531, and 8636. After asking why this patch was
> applied no one seemed to respond with anything useful. If you find this change in error, sorry, I
> tested it on as many systems as I could.
>
>
>
> Index: php4/ext/odbc/php_odbc.c
> diff -u php4/ext/odbc/php_odbc.c:1.77 php4/ext/odbc/php_odbc.c:1.78
> --- php4/ext/odbc/php_odbc.c:1.77 Tue Apr 10 09:26:27 2001
> +++ php4/ext/odbc/php_odbc.c Mon Apr 16 19:02:36 2001
> @@ -19,7 +19,7 @@
> +----------------------------------------------------------------------+
> */
>
> -/* $Id: php_odbc.c,v 1.77 2001/04/10 16:26:27 kevin Exp $ */
> +/* $Id: php_odbc.c,v 1.78 2001/04/17 02:02:36 kalowsky Exp $ */
>
> #include "php.h"
> #include "php_globals.h"
> @@ -2435,11 +2435,7 @@
>
> ZEND_FETCH_RESOURCE2(conn, odbc_connection *, pv_conn, -1, "ODBC-Link", le_conn,
> le_pconn);
>
> -#ifndef HAVE_DBMAKER
> - if ((*pv_onoff)) {
> -#else
> if (pv_onoff && (*pv_onoff)) {
> -#endif
> convert_to_long_ex(pv_onoff);
> rc = SQLSetConnectOption(conn->hdbc, SQL_AUTOCOMMIT,
> ((*pv_onoff)->value.lval) ?
>
This should be breaking something, no?
Either way an "if" statement is started therefore it needs to be finished.
-Sterling