Re: cvs: php-src(PHP_5_3) /ext/mbstring mbstring.c mbstring.h
| From: | Moriyoshi Koizumi | Date: | Fri, 25 Jul 2008 10:45:54 +0000 |
| Subject: | Re: cvs: php-src(PHP_5_3) /ext/mbstring mbstring.c mbstring.h | ||
| References: | 1 2 3 4 5 6 7 8 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-51583@lists.php.net to get a copy of this message | ||
I overlooked one more error; I wrote --SKIP-- everywhere --SKIPIF-- is expected :/
I committed the fix and now it should be ok ;)
Moriyoshi
On 2008/07/25, at 19:47, Antony Dovgal wrote:
On 25.07.2008 14:36, Moriyoshi Koizumi wrote:ini_set() returns the previously set value, so that's fine. But I eventually noticed that the logic is inversed - "or" should be "and" actually. Thanks for the heads-up.The tests still fail, though. Even with zend multibyte enabled. -- ext/mbstring/tests/zend_multibyte-02.diff -- 001+ string(18) "e38386e382b9e38388" 001- string(12) "836583588367" -- ext/mbstring/tests/zend_multibyte-03.diff -- 001+ string(18) "e38386e382b9e38388" 001- string(12) "a5c6a5b9a5c8" -- ext/mbstring/tests/zend_multibyte-04.diff -- 001+ string(12) "836583588367" 001- string(18) "e38386e382b9e38388" -- ext/mbstring/tests/zend_multibyte-05.diff -- 001+ string(18) "e38386e382b9e38388" 001- string(16) "3f3f3fe9b4bb3f3f" -- ext/mbstring/tests/zend_multibyte-06.diff -- 001+ string(18) "e38386e382b9e38388" 001- string(12) "836583588367" -- ext/mbstring/tests/zend_multibyte-07.diff -- 001+ string(18) "e38386e382b9e38388" 001- string(12) "a5c6a5b9a5c8" -- ext/mbstring/tests/zend_multibyte-08.diff -- 001+ string(12) "836583588367" 001- string(18) "e38386e382b9e38388" -- ext/mbstring/tests/zend_multibyte-09.diff -- 001+ string(18) "e38386e382b9e38388" 001- string(16) "3f3f3fe9b4bb3f3f" --Wbr, Antony Dovgal