Re: cvs: php-src / Makefile.gcov

On Wed, 30 Jul 2008, Marcus Boerger wrote: > Wednesday, July 30, 2008, 9:50:18 AM, you wrote: > > > On Tue, 29 Jul 2008, Pierre Joye wrote: > > >> On Tue, Jul 29, 2008 at 10:10 AM, Marcus Boerger <helly@php.net> wrote: > >> > helly Tue Jul 29 08:10:31 2008 UTC > >> > > >> > Modified files: > >> > /php-src Makefile.gcov > >> > Log: > >> > - Exclude bundled libs from gcov processing > >> > >> Why? It makes sense to keep it, for example for GD as the lib and > >> php are well integrated. > > > I'd like the same for libmagic (very new, unknown) and timelib > > (because it's well integrated). > > timelib, yeah unknown, yeah new, so is it us to write a test system > for them? no! Uhm yes - we need to support it - libmagic requires most likely a fork. And what does it matter if there are a few more libs in here?! > datelib, cool, great, damn well tested, so no need to test again. Or do you > want all your libdate tests to php? Yes, because the behavior in PHP is some times slightly different -- and should be. regards, Derick -- HEAD before 5_3!: http://tinyurl.com/6d2esb http://derickrethans.nl | http://ezcomponents.org | http://xdebug.org