Re: cvs: php-src /ext/standard/tests/file clearstatcache_001.phpt
| From: | Jani Taskinen | Date: | Fri, 15 Aug 2008 15:15:33 +0000 |
| Subject: | Re: cvs: php-src /ext/standard/tests/file clearstatcache_001.phpt | ||
| Groups: | php.cvs | ||
| Request: | Send a blank email to php-cvs+get-52374@lists.php.net to get a copy of this message | ||
Because it was the easiest way to fix this: __FILE__ is not same with clean and actual test sections,
so the clean section code did nothing however you run the tests..
btw. run-tests.php is such a mess that I don't want to even look at the code anymore. f.e. Are the tests in sapi/tests/ supposed to work in any branch..?
--Jani
Marcus Boerger [helly@php.net] kirjoitti:
Hello Jani, why did you drop the clean section here? Some test developers prefer to have the cleanup code reside in the clean section as that allows them to run the tests without cleanup while normall the tests would clean after themselves. marcus Friday, August 15, 2008, 1:25:27 AM, you wrote:jani Thu Aug 14 23:25:27 2008 UTCModified files: /php-src/ext/standard/tests/file clearstatcache_001.phpt Log:- Fix test: Do not leave your crap behind! http://cvs.php.net/viewvc.cgi/php-src/ext/standard/tests/file/clearstatcache_001.phpt?r1=1.3&r2=1.4&diff_format=u Index: php-src/ext/standard/tests/file/clearstatcache_001.phpt diff -u php-src/ext/standard/tests/file/clearstatcache_001.phpt:1.3 php-src/ext/standard/tests/file/clearstatcache_001.phpt:1.4--- php-src/ext/standard/tests/file/clearstatcache_001.phpt:1.3 Sun Aug 10 12:06:49 2008 +++ php-src/ext/standard/tests/file/clearstatcache_001.phpt Thu Aug 14 23:25:27 2008@@ -30,9 +30,6 @@ clearstatcache(true, __FILE__ . "_link1"); var_dump(realpath(__FILE__ . "_link2")); -?>> ---CLEAN-- -<?php @rmdir(__FILE__ . "_dir1"); @rmdir(__FILE__ . "_dir2"); @unlink(__FILE__ . "_link1"); Best regards, Marcus