Re: cvs: php-src(PHP_5_3) /ext/standard/tests/file popen_pclose_error-win32-debug.phpt popen_pclose_error-win32.phpt

hi Tony, On Sat, Aug 16, 2008 at 12:28 PM, Antony Dovgal <tony@daylessday.org> wrote: > There is something wrong with this SKIPIF section. > > On 15.08.2008 23:01, Pierre-Alain Joye wrote: >> >> >> >> http://cvs.php.net/viewvc.cgi/php-src/ext/standard/tests/file/popen_pclose_error-win32-debug.phpt?view=markup&rev=1.1 >> Index: php-src/ext/standard/tests/file/popen_pclose_error-win32-debug.phpt >> +++ php-src/ext/standard/tests/file/popen_pclose_error-win32-debug.phpt >> --TEST-- >> Test popen() and pclose function: error conditions >> >> --SKIPIF-- >> <?php >> if(substr(PHP_OS, 0, 3) != 'WIN' && PHP_DEBUG)) die("skip Not Valid >> for >> Linux"); > > There is a parse error in this line (see "))"). Sorry, commited from the wrong tree, fixed now. > Also I don't get why it's not valid only for debug builds. We have extra warning in debug mode on Windows (CRT warning printed out as warning), see dummy_invalid_parameter_handler in main/main.c > And btw Windows and Linux are not the only two systems we support. And? These tests are for windows and also improve portability across OSes. Are you asking me to work on other OSes as well? Cheers, -- Pierre http://blog.thepimp.net | http://www.libgd.org