Re: cvs: php4 /ext/standard exec.c

Sascha, the man page says that it only accepts "r" and "w". This is unlike the fopen() man page which mentions ignoring "b". Anyway it was like this before so I don't see a reason not to leave it (besides not wanting to have an #ifdef). Andi At 11:07 PM 6/27/00 +0200, Sascha Schumann wrote:

On Tue, 27 Jun 2000, Stanislav Malyshev wrote:

SS>>     The `b' should be ignored by all STDIO implementations which
SS>>     don't differentiate between text and binary files. Did you
SS>>     find an implementation which does not behave correctly?

I've read source of glibc popen. And there it compares popen argument to be "r" or "w" only. One character. It doesn't work otherwise. And yes, I was bitten by this - I don't usually enjoy reading glibc sources without good reason, call me boring on that :)

    According to SuS II, the behaviour of the implementation is
    undefined, if the application specifies non-standard
    characters in the type argument to popen(). In plain English,
    you probably will get a segfault on Solaris, so that the
    change is valid.

    Nevertheless, it looks like the mode "rb" should work with
    the current glibc code (2.2 CVS) and glibc-2.1.3, because the
    'b' is ignored.

    - Sascha

-- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, e-mail: php-cvs-unsubscribe@lists.php.net For additional commands, e-mail: php-cvs-help@lists.php.net To contact the list administrators, e-mail: php-list-admin@lists.php.net

--- Andi Gutmans <andi@zend.com> http://www.zend.com/