Re: cvs: php-src(PHP_5_3) /ext/standard basic_functions.c
| From: | Marcus Boerger | Date: | Wed, 20 Aug 2008 11:21:10 +0000 |
| Subject: | Re: cvs: php-src(PHP_5_3) /ext/standard basic_functions.c | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-52528@lists.php.net to get a copy of this message | ||
Hello Antony,
Wednesday, August 20, 2008, 11:01:25 AM, you wrote:
> tony2001 Wed Aug 20 09:01:25 2008 UTC
> Modified files: (Branch: PHP_5_3)
> /php-src/ext/standard basic_functions.c
> Log:
> fix warning
>
>
>
> http://cvs.php.net/viewvc.cgi/php-src/ext/standard/basic_functions.c?r1=1.725.2.31.2.64.2.56&r2=1.725.2.31.2.64.2.57&diff_format=u
> Index: php-src/ext/standard/basic_functions.c
> diff -u php-src/ext/standard/basic_functions.c:1.725.2.31.2.64.2.56
> php-src/ext/standard/basic_functions.c:1.725.2.31.2.64.2.57
> --- php-src/ext/standard/basic_functions.c:1.725.2.31.2.64.2.56 Tue Aug 19 15:14:46 2008
> +++ php-src/ext/standard/basic_functions.c Wed Aug 20 09:01:24 2008
> @@ -18,7 +18,7 @@
>
> +----------------------------------------------------------------------+
> */
>
> -/* $Id: basic_functions.c,v 1.725.2.31.2.64.2.56 2008/08/19 15:14:46 tony2001 Exp $ */
> +/* $Id: basic_functions.c,v 1.725.2.31.2.64.2.57 2008/08/20 09:01:24 tony2001 Exp $ */
>
> #include "php.h"
> #include "php_streams.h"
> @@ -4958,7 +4958,7 @@
> */
> static int add_config_entry_cb(zval *entry TSRMLS_DC, int num_args,
> va_list args, zend_hash_key *hash_key)
> {
> - zval *retval = (zval *) va_arg(args, int);
> + zval *retval = (zval *)(long)va_arg(args, int);
This cannot be correct as there are systems where sizeof(int) <
sizeof(void*).
> zval *tmp;
>
> if (Z_TYPE_P(entry) == IS_STRING) {
Best regards,
Marcus