Re: cvs: php-src / NEWS

Patrick van Kleef wrote:

Hi Jani,

iodbc        Mon Sep  1 08:37:22 2008 UTC
 Modified files:                  /php-src    NEWS   Log:

- fixes for ext/odbc http://cvs.php.net/viewvc.cgi/php-src/NEWS?r1=1.2165&r2=1.2166&diff_format=u Index: php-src/NEWS diff -u php-src/NEWS:1.2165 php-src/NEWS:1.2166

--- php-src/NEWS:1.2165    Wed Aug  6 05:51:38 2008
+++ php-src/NEWS    Mon Sep  1 08:37:22 2008

@@ -50,3 +50,7 @@ - Added str_getcsv() function. (Sara) - Fixed bug #40325 (Vary: header missing in gzip output handlers). (Mike) +- Fixed bug #43666) (Fixed code to use ODBC 3.52 datatypes for 64bit systems). + (iodbc) +- Fixed bug #43668) (Added odbc.default_cursortype to control the ODBC + cursormodel). (iodbc)

Do NOT add NEWS entries to "higher" branches if the same stuff is done in "lower" ones. And you still haven't merged this fix to PHP_5_2..

Would be handy if these "rules" was documented anywhere. I was thrown in deep end on friday, and i have tried to find out how you guys work.

Yeah, well...I'm not keen on documenting this since it's kinda "fuzzy" logic. :)

I apologize if i makde any mistakes, but since this is CVS, just go in and fix it. For now i will not touch NEWS and let you or someone else do that.

Now you know basics, don't be afraid of doing it. Just try remember these basic rules. And I don't bite, I just bark. :D

As for 5.2 i am testing right the patch right now. I will commit it as soon as it passes my testing.

Excellent! It would be cool if you could fix the rest of the ODBC bugs too, there are only (!) 21 open bugs for odbc: http://bugs.php.net/search.php?cmd=display&bug_type[]=ODBC+related&status=Open --Jani