Re: cvs: php-src(PHP_5_3) /ext/mbstring mbstring.c

On 03.08.2008 04:04, Moriyoshi Koizumi wrote:

+/* {{{ static PHP_INI_MH(OnUpdate_mbstring_internal_encoding) */ +static PHP_INI_MH(OnUpdate_mbstring_internal_encoding) +{ + if (stage == PHP_INI_STAGE_STARTUP || stage == PHP_INI_STAGE_SHUTDOWN) { + return _php_mb_ini_mbstring_internal_encoding_set(new_value, new_value_length TSRMLS_CC); + } else { + // the corresponding mbstring globals needs to be set according to the + // ini value in the later stage because it never falls back to the + // default value if 1. no value for mbstring.internal_encoding is given, + // 2. mbstring.language directive is processed in per-dir or runtime + // context and 3. call to the handler for mbstring.language is done + // after mbstring.internal_encoding is handled. + return SUCCESS; + } +} +/* }}} */ +

The docs say mbstring.internal_encoding is PHP_INI_ALL, but this change makes it in fact PHP_INI_SYSTEM. Also why allow using mb_internal_encoding() and disallow changing the ini setting? -- Wbr, Antony Dovgal