Re: cvs: php-src /ext/session/tests 020.phpt
| From: | Pierre Joye | Date: | Sun, 07 Sep 2008 13:30:47 +0000 |
| Subject: | Re: cvs: php-src /ext/session/tests 020.phpt | ||
| References: | 1 2 | Groups: | php.cvs php.internals |
| Request: | Send a blank email to php-cvs+get-52953@lists.php.net to get a copy of this message | ||
hi Kalle,
On Sun, Sep 7, 2008 at 3:13 PM, Hannes Magnusson
<hannes.magnusson@gmail.com> wrote:
> 2008/9/7 Kalle Sommer Nielsen <kalle@php.net>:
>> kalle Sun Sep 7 00:42:29 2008 UTC
>>
>> Modified files:
>> /php-src/ext/session/tests 020.phpt
>> Log:
>> Fix test on Windows
>>
>>
>> http://cvs.php.net/viewvc.cgi/php-src/ext/session/tests/020.phpt?r1=1.5&r2=1.6&diff_format=u
>> Index: php-src/ext/session/tests/020.phpt
>> diff -u php-src/ext/session/tests/020.phpt:1.5 php-src/ext/session/tests/020.phpt:1.6
>> --- php-src/ext/session/tests/020.phpt:1.5 Mon Feb 13 10:23:57 2006
>> +++ php-src/ext/session/tests/020.phpt Sun Sep 7 00:42:29 2008
>> @@ -6,7 +6,7 @@
>> session.use_cookies=0
>> session.cache_limiter=
>> session.use_trans_sid=1
>> -arg_separator.output="&"
>> +arg_separator.output=&
That's the wrong fix and it certainly breaks on non windows now. The
correct fix has been posted to internals and QA some weeks ago. If we
drop the quotes in the ini section, we can then use escapeshellargs in
run-tests.php, that's cleaner, safer and more portable.
Cheers,
--
Pierre
http://blog.thepimp.net | http://www.libgd.org