Re: cvs: php-src /ext/mysqli mysqli.c /ext/mysqlnd mysqlnd_structs.h mysqlnd_wireprotocol.c
| From: | Pierre Joye | Date: | Mon, 15 Sep 2008 19:44:12 +0000 |
| Subject: | Re: cvs: php-src /ext/mysqli mysqli.c /ext/mysqlnd mysqlnd_structs.h mysqlnd_wireprotocol.c | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-53165@lists.php.net to get a copy of this message | ||
hi Andrey,
On Mon, Sep 15, 2008 at 8:07 PM, Andrey Hristov <andrey@php.net> wrote:
> *(p + len) = save;
> + } else if (as_int_or_float && perm_bind.php_type == IS_DOUBLE)
> + {
> + zend_uchar save = *(p + len);
> + /* We have to make it ASCIIZ temporarily */
> + *(p + len) = '\0';
> + double v = atof((char *) p);
> + ZVAL_DOUBLE(*current_field, v);
> + *(p + len) = save;
I don't want to sound trash but can you please try to put the
declaration first in a given context? For example:
Valid:
{
int a;
foo();
}
Not valid:
{
foo();
int a;
}
Thanks :)
Cheers,
--
Pierre
http://blog.thepimp.net | http://www.libgd.org