Re: cvs: php-src /ext/session php_session.h session.c

Hi, On Thursday 18 September 2008 10:37:04 Hannes Magnusson wrote: > On Wed, Sep 17, 2008 at 19:22, Arnaud Le Blanc <lbarnaud@php.net> wrote: > > lbarnaud Wed Sep 17 17:22:07 2008 UTC > > > > Modified files: > > /php-src/ext/session php_session.h session.c > > Log: > > Added ability to cancel upload in rfc1867 handler > > How exactly does this work? > setting $_SESSION["progress_key"]["cancel_upload"] = true will cancel > the upload? Ok.. will it cut off the apache connection and remove the > temporary file or..? Actually this just causes the session's rfc1867 callback to return FAILURE, which causes the POST handler to remove the temporary file and search the next boundary. > > -Hannes > > p.s. I would appreciate if all new features and changes of behavior > contain "[DOC]" in the commit message so the commit gets CCed to the > phpdoc@ mailinglist so people don't have to walk through hundreds of > commits to see find what needs to be documented. > If only some people use it this feature is completely useless as then > we still have to walk though every commit to find the rest. > That's only in HEAD so I just documented that in the RFC for now and added an entry in doc/todo/undocumented. Regards, Arnaud