Re: cvs: php-src(PHP_5_3) /ext/phar/tests phar_oo_005.phpt

Hi Alexey, This test requires 5.3. Not 5.2, not 6.0, just 5.3. Yes the original's wrong, but so's the fix... probably needs strstr or substr rather than version_compare. - Steph ----- Original Message ----- From: "Alexey Zakhlestin" <indeyets@php.net> To: <php-cvs@lists.php.net> Sent: Tuesday, October 21, 2008 1:26 PM Subject: [PHP-CVS] cvs: php-src(PHP_5_3) /ext/phar/tests phar_oo_005.phpt

indeyets Tue Oct 21 12:26:36 2008 UTC

 Modified files:              (Branch: PHP_5_3)

/php-src/ext/phar/tests phar_oo_005.phpt Log: fixed wrong check for version http://cvs.php.net/viewvc.cgi/php-src/ext/phar/tests/phar_oo_005.phpt?r1=1.9.2.2&r2=1.9.2.3&diff_format=u Index: php-src/ext/phar/tests/phar_oo_005.phpt diff -u php-src/ext/phar/tests/phar_oo_005.phpt:1.9.2.2 php-src/ext/phar/tests/phar_oo_005.phpt:1.9.2.3 --- php-src/ext/phar/tests/phar_oo_005.phpt:1.9.2.2 Fri Aug 1 13:38:47 2008 +++ php-src/ext/phar/tests/phar_oo_005.phpt Tue Oct 21 12:26:35 2008 @@ -4,7 +4,7 @@ <?php if (!extension_loaded("phar")) die("skip"); if (!extension_loaded("spl")) die("skip SPL not available"); -if (!version_compare(PHP_VERSION, "5.3", "==")) die("skip requires 5.3"); +if (!version_compare(PHP_VERSION, "5.3", ">=")) die("skip requires 5.3"); ?> --INI-- phar.require_hash=0 -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php