Re: cvs: php-src /ext/phar/tests phar_oo_005.phpt

Alexey Zakhlestin wrote: > indeyets Tue Oct 21 13:00:30 2008 UTC > > Modified files: > /php-src/ext/phar/tests phar_oo_005.phpt > Log: > MFB: proper check for php-version > > > http://cvs.php.net/viewvc.cgi/php-src/ext/phar/tests/phar_oo_005.phpt?r1=1.11&r2=1.12&diff_format=u > Index: php-src/ext/phar/tests/phar_oo_005.phpt > diff -u php-src/ext/phar/tests/phar_oo_005.phpt:1.11 > php-src/ext/phar/tests/phar_oo_005.phpt:1.12 > --- php-src/ext/phar/tests/phar_oo_005.phpt:1.11 Fri Aug 1 13:36:18 2008 > +++ php-src/ext/phar/tests/phar_oo_005.phpt Tue Oct 21 13:00:29 2008 > @@ -4,7 +4,8 @@ > <?php > if (!extension_loaded("phar")) die("skip"); > if (!extension_loaded("spl")) die("skip SPL not available"); > -if (!version_compare(PHP_VERSION, "5.3", "==")) die("skip requires > 5.3"); > +if (version_compare(PHP_VERSION, "5.3", "<") or > version_compare(PHP_VERSION, "5.4", ">=")) > + die("skip requires 5.3"); > ?> > --INI-- > phar.require_hash=0 > > Hi Alexey, Thanks for this fix. Would you mind merging it to pecl/phar/tests/phar_oo_005.phpt? Thanks, Greg