Re: cvs: php-src(PHP_5_2) / NEWS /ext/standard math.c

On Wed, Oct 29, 2008 at 21:52, Hannes Magnusson <hannes.magnusson@gmail.com> wrote: > On Wed, Oct 29, 2008 at 21:17, Ilia Alshanetsky <iliaa@php.net> wrote: >> iliaa Wed Oct 29 20:17:33 2008 UTC >> >> Modified files: (Branch: PHP_5_2) >> /php-src NEWS >> /php-src/ext/standard math.c >> Log: >> >> MFB: Fixed bug #42294 (Unified solution for round() based on C99 round). > > > Is this really something you want to change minutes before latest RC > of (probably) the latest 5.2 release without any tests what so ever? > It looks to me that the likelihoods of change in behaviour are quite big.. > > And what about the bug reporters big fat note: > ..."DOCUMENT this behaviour so that anybody who wants to use the round > function knows exactly what expects him."? > That screams to me like he anticipates changes in behaviour which > really really should be documented.. and you neither tagged this > commit with [DOC] nor closed the report as "To be documented"? Hah! Fail! You did [DOC] it, the 5.3 commit \o/ But then, does this really belong in 5.2? -Hannes