Re: cvs: php-src(PHP_5_3) /ext/standard array.c basic_functions.c
| From: | Antony Dovgal | Date: | Tue, 25 Nov 2008 15:06:29 +0000 |
| Subject: | Re: cvs: php-src(PHP_5_3) /ext/standard array.c basic_functions.c | ||
| References: | 1 2 3 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-54466@lists.php.net to get a copy of this message | ||
On 25.11.2008 12:15, Stanislav Malyshev wrote:
> Hi!
>
>> All these tests fail after your patch:
...
> These tests expect BC breakage, which this patch fixes. So they need to
> be fixed, I guess.
Does this mean you didn't run the tests before applying the patch?
Or does this mean you've just ignored them?
In either case, please fix the tests, if you're sure they need fixing.
--
Wbr,
Antony Dovgal