Re: cvs: php4 /build buildcheck.sh

At 05:55 AM 5/3/2001 -0400, Stig Sæther Bakken wrote:

[Jani Taskinen <sniper@iki.fi>] On Thu, 3 May 2001, Sascha Schumann wrote:

lt_version=echo $lt_pversion|sed -e 's/\([a-z]*\)$/.\1/' IFS=.; set $lt_version; IFS=' ' -if test "$1" -gt "1" || test "$2" -gt "3" || test "$2" = "3" &&

(test "$3" = "c" || test "$3" -ge "3")

+ +if test "$1$2$3" -ge "133" || (test "$1" = "1" && test "$2" -ge "4")

There is no provision that the third letter is always a number (think of 1.3c). Hence the above patch is broken.

I know now. This didn't fix anything. But isn't that check for libtool version useless? As the bundled libtool is the one that is used anyway?? Libtool is only bundled in the releases. With a clean CVS checkout you get a copy of libtool when running "libtoolize".

Why doesn't the previous code work? Doesn't it say that if $2 is greater than 3 it'll work? Why doesn't it work for 1.4? Andi