Re: cvs: php4 /ext/standard var.c
| From: | Stanislav Malyshev | Date: | Thu, 29 Jun 2000 15:54:18 +0000 |
| Subject: | Re: cvs: php4 /ext/standard var.c | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-554@lists.php.net to get a copy of this message | ||
ZS>> > Because this is faster. calling memcpy and then strtolower makes two
ZS>> > passes on the string, while this one makes one pass. It could be optimized
ZS>> > too, I believe (by using potinters instead of indexes), so if anybody
ZS>> > wants to, please do it.
ZS>>
ZS>> zend_str_tolower() doesn't call memcmp(), it replaces the characters
ZS>> in-place. Since it does use pointers, it's in fact faster than your code.
Yeah, I know. There *was* memcpy before I've removed it. So you should do
memcpy+str_tolower.
--
Stanislav Malyshev stas@zend.com
+972-3-6139665