RE: [PHP-CVS] cvs: php-src /sapi/nsapi nsapi.c

Yeeees! I've seen this comment here: /* vs.net 2005 has a 64-bit time_t. This will likely break * 3rdParty libs that were built with older compilers; switch * back to 32-bit */ #ifndef _WIN64 # define _USE_32BIT_TIME_T 1 #endif If somebody wants to remove this he should be prepared to have failures in NSAPI :-) Thanks, Uwe ----- Uwe Schindler thetaphi@php.net - http://www.php.net NSAPI SAPI developer Bremen, Germany > -----Original Message----- > From: Pierre Joye [mailto:pierre.php@gmail.com] > Sent: Sunday, January 11, 2009 2:41 PM > To: Uwe Schindler > Cc: php-cvs@lists.php.net > Subject: Re: [PHP-CVS] cvs: php-src /sapi/nsapi nsapi.c > > On Sun, Jan 11, 2009 at 2:39 PM, Uwe Schindler <thetaphi@php.net> wrote: > > thetaphi Sun Jan 11 13:39:01 2009 UTC > > > > Modified files: > > /php-src/sapi/nsapi nsapi.c > > Log: > > add sanity check for time_t size of win32 > > > > http://cvs.php.net/viewvc.cgi/php- > src/sapi/nsapi/nsapi.c?r1=1.101&r2=1.102&diff_format=u > > Index: php-src/sapi/nsapi/nsapi.c > > diff -u php-src/sapi/nsapi/nsapi.c:1.101 php- > src/sapi/nsapi/nsapi.c:1.102 > > --- php-src/sapi/nsapi/nsapi.c:1.101 Tue Jan 6 13:45:30 2009 > > +++ php-src/sapi/nsapi/nsapi.c Sun Jan 11 13:39:01 2009 > > @@ -17,7 +17,7 @@ > > +-------------------------------------------------------------------- > --+ > > */ > > > > -/* $Id: nsapi.c,v 1.101 2009/01/06 13:45:30 thetaphi Exp $ */ > > +/* $Id: nsapi.c,v 1.102 2009/01/11 13:39:01 thetaphi Exp $ */ > > > > /* > > * PHP includes > > @@ -55,7 +55,14 @@ > > #define XP_UNIX > > #endif > > #endif > > - > > + > > +/* > > + * For windows do some sanity checks, because time_t must be 32bit for > NSAPI on win32 > > + */ > > +#if defined(PHP_WIN32) && !defined(_WIN64) && sizeof(time_t)!=4 > > +#error "NSAPI module needs time_t to have a size of 32 bits on win32" > > +#endif > > We already do this check in the main configuration file, you may want > to rely on it instead. > > -- > Pierre > > http://blog.thepimp.net | > http://www.libgd.org