Re: cvs: php-src(PHP_5_2) / NEWS /ext/soap php_http.c
| From: | Hannes Magnusson | Date: | Mon, 19 Jan 2009 22:17:16 +0000 |
| Subject: | Re: cvs: php-src(PHP_5_2) / NEWS /ext/soap php_http.c | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-55774@lists.php.net to get a copy of this message | ||
On Mon, Jan 19, 2009 at 22:57, Ilia Alshanetsky <iliaa@php.net> wrote:
> iliaa Mon Jan 19 21:57:47 2009 UTC
>
> Modified files: (Branch: PHP_5_2)
> /php-src/ext/soap php_http.c
> /php-src NEWS
> Log:
> Fixed bug #47131 (SOAP Extension ignores "user_agent" ini setting).
>
>
>
> http://cvs.php.net/viewvc.cgi/php-src/ext/soap/php_http.c?r1=1.77.2.11.2.16&r2=1.77.2.11.2.17&diff_format=u
> Index: php-src/ext/soap/php_http.c
> diff -u php-src/ext/soap/php_http.c:1.77.2.11.2.16 php-src/ext/soap/php_http.c:1.77.2.11.2.17
> --- php-src/ext/soap/php_http.c:1.77.2.11.2.16 Wed Dec 31 11:17:43 2008
> +++ php-src/ext/soap/php_http.c Mon Jan 19 21:57:45 2009
> @@ -17,7 +17,7 @@
> | Dmitry Stogov <dmitry@zend.com> |
> +----------------------------------------------------------------------+
> */
> -/* $Id: php_http.c,v 1.77.2.11.2.16 2008/12/31 11:17:43 sebastian Exp $ */
> +/* $Id: php_http.c,v 1.77.2.11.2.17 2009/01/19 21:57:45 iliaa Exp $ */
>
> #include "php_soap.h"
> #include "ext/standard/base64.h"
> @@ -438,7 +438,11 @@
> smart_str_appendl(&soap_headers, Z_STRVAL_PP(tmp),
> Z_STRLEN_PP(tmp));
> smart_str_append_const(&soap_headers, "\r\n");
> }
> - } else{
> + } else if (FG(user_agent)) {
> + smart_str_append_const(&soap_headers, "User-Agent: ");
> + smart_str_appends(&soap_headers, FG(user_agent));
> + smart_str_append_const(&soap_headers, "\r\n");
> + } else {
> smart_str_append_const(&soap_headers, "User-Agent:
> PHP-SOAP/"PHP_VERSION"\r\n");
> }
Why not check the context for user_agent while you are at it?
-Hannes