Re: cvs: php-src(PHP_5_3) / NEWS /ext/bz2 bz2_filter.c
| From: | Greg Beaver | Date: | Fri, 06 Feb 2009 02:20:56 +0000 |
| Subject: | Re: cvs: php-src(PHP_5_3) / NEWS /ext/bz2 bz2_filter.c | ||
| References: | 1 2 3 4 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-56123@lists.php.net to get a copy of this message | ||
Jani Taskinen wrote:
> Greg Beaver kirjoitti:
>> Jani Taskinen wrote:
>>> Greg Beaver wrote:
>>>> cellog Tue Feb 3 18:56:26 2009 UTC
>>>>
>>>> Modified files: (Branch: PHP_5_3)
>>>> /php-src NEWS /php-src/ext/bz2 bz2_filter.c Log:
>>>> Re-Fixed bug #46026 (bz2.decompress/zlib.inflate filter tries to
>>>> decompress after end of stream)
>>>>
>>>>
>>>> http://cvs.php.net/viewvc.cgi/php-src/NEWS?r1=1.2027.2.547.2.965.2.484&r2=1.2027.2.547.2.965.2.485&diff_format=u
>>>>
>>>>
>>>> Index: php-src/NEWS
>>>> diff -u php-src/NEWS:1.2027.2.547.2.965.2.484
>>>> php-src/NEWS:1.2027.2.547.2.965.2.485
>>>> --- php-src/NEWS:1.2027.2.547.2.965.2.484 Tue Feb 3 18:29:25 2009
>>>> +++ php-src/NEWS Tue Feb 3 18:56:25 2009
>>>> @@ -6,7 +6,8 @@
>>>> - Fixed bug #47085 (rename() returns true even if the file in PHAR
>>>> does not exist). (Greg)
>>>> - Fixed bug #47031 (Fix constants in DualIterator example). (Etienne)
>>>> - Fixed bug #46347 (parse_ini_file() doesn't support * in keys).
>>>> (Nuno)
>>>> -
>>>> +- Re-Fixed bug #46026 (bz2.decompress/zlib.inflate filter tries to
>>>> decompress after
>>>> + end of stream). (Greg)
>>> "Re-Fixed" ? Please don't invent stuff like this into NEWS. It's
>>> either Fixed or not.
>> sorry for offending your delicate sensibilities. Feel free to Re-Commit
>> with the corrected name for Fixed.
>>> Also, why isn't this fix MFH'd to PHP_5_2?
>> The original fix was merged, minus the feature addition, but 5.2 went RC
>> yesterday, so I didn't think it wise to randomly commit.
>>
>> Any other questions?
>
> Yes, did your gerbil die or what's with the attitude?
:) perhaps it's the barrage of nit-picking messages from 3 different
people over insignificant details (and then the "yeah" replies) when the
fix itself was a bit of work in the first place? It's all right though,
I know that none of us can help being smug when others mess up, I do the
same thing in my own special way.