Re: cvs: php4 /ext/sablot config.m4 /ext/xslt config.m4

On Wed, 9 May 2001, Sascha Schumann wrote: > On Tue, 8 May 2001, Jani Taskinen wrote: > > > sniper Tue May 8 15:17:59 2001 EDT > > > > Modified files: > > /php4/ext/sablot config.m4 > > /php4/ext/xslt config.m4 > > Log: > > No need to show these if they are not used. > > PHP_ARG_* always sets ext_shared, so if you interleave > calls to PHP_ARG_*, latter calls will overwrite the results > of earlier invocations. > > E.g. in this commit, > > > if test "$PHP_SABLOT" != "no"; then > > + > > + PHP_ARG_WITH(expat-dir, libexpat dir for Sablotron 0.50, > > + [ --with-expat-dir=DIR Sablotron: libexpat dir for Sablotron 0.50]) > > + > > the functionality of --with-sablot=shared gets broken. > > > -if test "$PHP_XSLT" != "no"; then > > + PHP_ARG_WITH(expat-dir, libexpat dir for Sablotron XSL support, > > + [ --with-expat-dir=DIR Sablotron: libexpat dir for Sablotron 0.50]) > > + > > Same here. > > The commits should be either reverted or precautions should > be taken to preserve the value of ext_shared until its used > later in PHP_EXTENSION(). > They really should be reverted, --with-expat-dir should always be present whether or not sablot is enabled. -Sterling > - Sascha Experience IRCG > http://schumann.cx/ > http://schumann.cx/ircg > > >