Re: cvs: php-src(PHP_5_3) /ext/standard/tests/strings highlight_file.phpt ZendEngine2 zend_language_scanner.c zend_language_scanner.l
zend_language_scanner_defs.h zend_stream.h

Hello shire, Wednesday, March 11, 2009, 11:55:00 PM, you wrote: > Marcus Boerger wrote: >> Hello Brian, >> >> thanks for looking into this. The patch looks pretty good for the most >> part. But you effectively create a BC issue here becuase you no longer >> allow \0 inside a php file or string. You might want to test whether >> a length check in your NULL rules fixes that. That check would either >> return the \0 if inside the code or return 0 if in the lookahead block. > Thanks Marcus, > Sorry I probably should have worked through that more. I'll try that > and see if I can work around this correctly this evening, perhaps another > possibility is that I could handle the null chars in places where they > are valid such as within strings. (Are there any other constructs that > could contain these that I might be missing?) I think it is only correct outside php scope and inside strings, and here- as well as now-docs. marcus