Re: cvs: php-src(PHP_5_3) / NEWS /ext/standard filters.c http_fopen_wrapper.c /ext/standard/tests/filters chunked_001.phpt

Hannes Magnusson wrote:

On Thu, Apr 16, 2009 at 12:16, Dmitry Stogov <dmitry@php.net> wrote:

dmitry          Thu Apr 16 10:16:27 2009 UTC

 Added files:                 (Branch: PHP_5_3)

/php-src/ext/standard/tests/filters chunked_001.phpt Modified files:

   /php-src    NEWS
   /php-src/ext/standard       filters.c http_fopen_wrapper.c

Log: - Added "dechunk" filter which can decode HTTP responces with chunked transfer-encoding. HTTP streams use this filter automatically in case "Transfer-Encoding: chunked" header presents in responce. It's possible to disable this behaviour using "http"=>array("auto_decode"=>0) in stream context - Fixed bug #47021 (SoapClient stumbles over WSDL delivered with "Transfer-Encoding: chunked")

Although its great that this is implemented as a filter I'm a bit sceptical on removing the header from the response, and enabling this by default is quite a big change considering PHP has never supported chunked encoding and bunch of userland implementations exist for it. -Hannes The header needs to be taken out so the caller knows that the content is no longer chunked. It would however be nice if some header was added indicating that the data had been chunked. Similar to how ext/http does it where it changes the Transfer-Encoding header to X-Original-Transfer-Encoding.

Rob