Re: cvs: php-src(PHP_5_2) / run-tests.php
| From: | Hannes Magnusson | Date: | Sun, 26 Apr 2009 11:25:50 +0000 |
| Subject: | Re: cvs: php-src(PHP_5_2) / run-tests.php | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-57277@lists.php.net to get a copy of this message | ||
On Sat, Apr 25, 2009 at 18:54, Jani Taskinen <jani@php.net> wrote:
> jani Sat Apr 25 16:54:50 2009 UTC
>
> Modified files: (Branch: PHP_5_2)
> /php-src run-tests.php
> Log:
> - Fix bad check (Hannes, please test stuff you commit..)
>
>
> http://cvs.php.net/viewvc.cgi/php-src/run-tests.php?r1=1.226.2.37.2.61&r2=1.226.2.37.2.62&diff_format=u
> Index: php-src/run-tests.php
> diff -u php-src/run-tests.php:1.226.2.37.2.61 php-src/run-tests.php:1.226..2.37.2.62
> --- php-src/run-tests.php:1.226.2.37.2.61 Thu Apr 16 13:43:28 2009
> +++ php-src/run-tests.php Sat Apr 25 16:54:50 2009
> @@ -24,7 +24,7 @@
> +----------------------------------------------------------------------+
> */
>
> -/* $Id: run-tests.php,v 1.226.2.37.2.61 2009/04/16 13:43:28 bjori Exp $ */
> +/* $Id: run-tests.php,v 1.226.2.37.2.62 2009/04/25 16:54:50 jani Exp $ */
>
> /* Sanity check to ensure that pcre extension needed by this script is available.
> * In the event it is not, print a nice error message indicating that this script will
> @@ -71,14 +71,15 @@
> define("PHP_MAJOR_VERSION", $major);
> }
>
> -// __DIR__ and FILE_BINARY is available from 5.3.0
> +// __DIR__ is available from 5.3.0
> if (PHP_VERSION_ID < 50300) {
> define('__DIR__', realpath(dirname(__FILE__)));
> - define('FILE_BINARY', 0);
> + // FILE_BINARY is available from 5.2.7
Greeaat. I love it when people merge random features without any headsup.
The docs say 5.3.0.
-Hannes