Re: cvs: php-src(PHP_5_3) / NEWS /ext/pdo_sqlite sqlite_statement.c
| From: | Antony Dovgal | Date: | Fri, 08 May 2009 08:17:21 +0000 |
| Subject: | Re: cvs: php-src(PHP_5_3) / NEWS /ext/pdo_sqlite sqlite_statement.c | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-57628@lists.php.net to get a copy of this message | ||
On 08.05.2009 03:29, Matteo Beccati wrote:
> #ifdef HAVE_CONFIG_H
> #include "config.h"
> @@ -265,11 +265,6 @@
> case SQLITE3_TEXT:
> *ptr = (char*)sqlite3_column_text(S->stmt, colno);
> *len = sqlite3_column_bytes(S->stmt, colno);
> - if (*len) {
> - /* sqlite3.h says "the NUL terminator is included in the byte count
> - * for TEXT values" */
> - *len--;
> - }
> return 1;
It doesn't look like no-op to me, but it's not clear what's being decremented.
I'd say it should do (*len)-- if the comment in sqlite3.h is correct.
--
Wbr,
Antony Dovgal