Re: cvs: php-src(PHP_5_3) /ext/standard array.c

2009/5/10 Johannes Schlüter <johannes@php.net>: > On Sun, 2009-05-10 at 16:45 +0000, Etienne Kneuss wrote: >> colder                Sun May 10 16:45:21 2009 UTC >> >>   Modified files:              (Branch: PHP_5_3) >>     /php-src/ext/standard     array.c >>   Log: >>   MFB: Fix #48224 (Remove incorrect shuffle) > > Any chance to cover this in a test? - I know it involves randomness. > > Maybe multiple calls to array_rand() and check if it's always in right > order or something? Yeah, I added a === check which should have a low probability of passing with shuffles > > johannes > > > -- Etienne Kneuss http://www.colder.ch Men never do evil so completely and cheerfully as when they do it from a religious conviction. -- Pascal