Re: cvs: php-src(PHP_5_3) / NEWS /ext/xmlwriter php_xmlwriter.c

Did you notice the "assigned" field in the bug report? I had the patch already as well (wrote it on my way back home from the NL test fest, these bugs were found there while writing tests for xmlwriter :) Can you MFB it to 5.2 as well then? Small enough. Cheers, -- Pierre On Mon, May 11, 2009 at 2:21 PM, Ilia Alshanetsky <iliaa@php.net> wrote: > iliaa           Mon May 11 12:21:26 2009 UTC > >  Modified files:              (Branch: PHP_5_3) >    /php-src/ext/xmlwriter      php_xmlwriter.c >    /php-src    NEWS >  Log: > >  Fixed bug #48204 (xmlwriter_open_uri() does not emit warnings on invalid >  paths) > > > http://cvs.php.net/viewvc.cgi/php-src/ext/xmlwriter/php_xmlwriter.c?r1=1.20.2.12.2.15.2.11&r2=1.20.2.12.2.15.2.12&diff_format=u > Index: php-src/ext/xmlwriter/php_xmlwriter.c > diff -u php-src/ext/xmlwriter/php_xmlwriter.c:1.20.2.12.2.15.2.11 > php-src/ext/xmlwriter/php_xmlwriter.c:1.20.2.12.2.15.2.12 > --- php-src/ext/xmlwriter/php_xmlwriter.c:1.20.2.12.2.15.2.11   Wed Dec 31 11:15:47 2008 > +++ php-src/ext/xmlwriter/php_xmlwriter.c       Mon May 11 12:21:26 2009 > @@ -17,7 +17,7 @@ >   +----------------------------------------------------------------------+ >  */ > > -/* $Id: php_xmlwriter.c,v 1.20.2.12.2.15.2.11 2008/12/31 11:15:47 sebastian Exp $ */ > +/* $Id: php_xmlwriter.c,v 1.20.2.12.2.15.2.12 2009/05/11 12:21:26 iliaa Exp $ */ > >  #ifdef HAVE_CONFIG_H >  #include "config.h" > @@ -1755,6 +1755,7 @@ > >        valid_file = _xmlwriter_get_valid_file_path(source, resolved_path, MAXPATHLEN > TSRMLS_CC); >        if (!valid_file) { > +               php_error_docref(NULL TSRMLS_CC, E_WARNING, "Unable to resolve file > path"); >                RETURN_FALSE; >        } > > > http://cvs.php.net/viewvc.cgi/php-src/NEWS?r1=1.2027.2.547.2.965.2.596&r2=1.2027.2.547.2.965.2.597&diff_format=u > Index: php-src/NEWS > diff -u php-src/NEWS:1.2027.2.547.2.965.2.596 php-src/NEWS:1.2027.2.547.2..965.2.597 > --- php-src/NEWS:1.2027.2.547.2.965.2.596       Sun May 10 21:06:35 2009 > +++ php-src/NEWS        Mon May 11 12:21:26 2009 > @@ -39,6 +39,8 @@ >  - Added ability to throw exceptions from SQLite3 instead of warnings. (Scott) >  - Added startup notices for deprecated ini settings. (Kalle) > > +- Fixed bug #48204 (xmlwriter_open_uri() does not emit warnings on invalid > +  paths). (Ilia) >  - Fixed bug #48185 (warning: value computed is not used in >   pdo_sqlite_stmt_get_col line 271). (Matteo) >  - Fixed bug #48087 (call_user_method() invalid free of arguments). (Felipe) > > > > -- > PHP CVS Mailing List (http://www.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php > > -- Pierre http://blog.thepimp.net | http://www.libgd.org