Re: cvs: php-src /build order_by_dep.awk /ext/date config.m4 config0.m4 php_date.c ZendEngine2 zend.c
| From: | Johannes Schlüter | Date: | Wed, 13 May 2009 18:38:28 +0000 |
| Subject: | Re: cvs: php-src /build order_by_dep.awk /ext/date config.m4 config0.m4 php_date.c ZendEngine2 zend.c | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-57782@lists.php.net to get a copy of this message | ||
On Wed, 2009-05-13 at 00:45 +0000, Jani Taskinen wrote:
> Log:
> - Fixed bug #48247 (PHP crashes on errors during startup)
Looks good for 5.3 to me.
One comment though:
> cat > $ext_builddir/lib/timelib_config.h <<EOF
> #ifdef PHP_WIN32
> # include "config.w32.h"
> #else
> # include <php_config.h>
> #endif
> EOF
Any issue with this file being committed instead of being generated? -
Just to reduce the complexity and number of things that might break.
People using the timelib for other purpose should still be able to
overwrite this file ...
johannes