Re: cvs: php-src /ext/curl interface.c
| From: | Jani Taskinen | Date: | Mon, 18 May 2009 12:13:11 +0000 |
| Subject: | Re: cvs: php-src /ext/curl interface.c | ||
| References: | 1 2 3 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-57953@lists.php.net to get a copy of this message | ||
Pierre Joye wrote:
On Mon, May 18, 2009 at 2:07 PM, Jani Taskinen <jani.taskinen@sci.fi> wrote:You have missed 8 invalid parameters returning false parts. Also while adding the file:// thing, you added CS violating stuff, didn't add folding tags..etc. --JaniCan't you do it all in one commit? Now you've littered the log with these half-assed commits, and STILL didn't do everything..there are several "RETURN_FALSE;"'s there where simple "return" is necessary.I do, only missed the 2nd one... but I'm done now anyway. It is already less painful to merge head and 5.3