Re: cvs: php-src / unicode-todo.txt /ext/filter filter.c /ext/mbstring mb_gpc.c /ext/pcre php_pcre.c /ext/standard basic_functions.c
basic_functions.h php_string.h string.c /main SAPI.c SAPI.h php_globals.h php_variables.c php_variables.h rfc1867.c /sapi/apache mod_php.c
/sapi/apache2filter sapi_apache2.c /sapi/apache2handler sapi_apache2.c /sapi/cgi cgi_main.c ZendEngine2 zend.c zend_compile.c zend_compile.h
zend_globals.h
| From: | Andrei Zmievski | Date: | Sat, 23 May 2009 19:05:31 +0000 |
| Subject: | Re: cvs: php-src / unicode-todo.txt /ext/filter filter.c /ext/mbstring mb_gpc.c /ext/pcre php_pcre.c /ext/standard basic_functions.c basic_functions.h php_string.h string.c /main SAPI.c SAPI.h php_globals.h php_variables.c php_variables.h rfc1867.c /sapi/apache mod_php.c /sapi/apache2filter sapi_apache2.c /sapi/apache2handler sapi_apache2.c /sapi/cgi cgi_main.c ZendEngine2 zend.c zend_compile.c zend_compile.h zend_globals.h |
||
| References: | 1 2 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-58153@lists.php.net to get a copy of this message | ||
Jani Taskinen wrote:
Is this really correct (rfc1867.c): - register_http_post_files_variable(lbuf, s+1, http_post_files, 0 TSRMLS_CC); + register_raw_var(lbuf, s+1, strlen(s+1), files_vars TSRMLS_CC); That 'strlen(s+1)' looks kinda wrong..? And to not cause more compile failures, configure option --enable-maintainer-zts helps. :)It's correct. We're registering a string starting from s+1 position, so we need to get the length starting from that position too. -Andrei