cvs: php-src(PHP_5_3) /ext/xmlwriter php_xmlwriter.c
| From: | Pierre-Alain Joye | Date: | Tue, 26 May 2009 08:10:49 +0000 |
| Subject: | cvs: php-src(PHP_5_3) /ext/xmlwriter php_xmlwriter.c | ||
| Groups: | php.cvs | ||
| Request: | Send a blank email to php-cvs+get-58215@lists.php.net to get a copy of this message | ||
pajoye Tue May 26 08:10:49 2009 UTC
Modified files: (Branch: PHP_5_3)
/php-src/ext/xmlwriter php_xmlwriter.c
Log:
- add a note about the actual problen so we don't forget it
http://cvs.php.net/viewvc.cgi/php-src/ext/xmlwriter/php_xmlwriter.c?r1=1.20.2.12.2.15.2.14&r2=1.20.2.12.2.15.2.15&diff_format=u
Index: php-src/ext/xmlwriter/php_xmlwriter.c
diff -u php-src/ext/xmlwriter/php_xmlwriter.c:1.20.2.12.2.15.2.14
php-src/ext/xmlwriter/php_xmlwriter.c:1.20.2.12.2.15.2.15
--- php-src/ext/xmlwriter/php_xmlwriter.c:1.20.2.12.2.15.2.14 Mon May 25 16:09:27 2009
+++ php-src/ext/xmlwriter/php_xmlwriter.c Tue May 26 08:10:49 2009
@@ -17,7 +17,7 @@
+----------------------------------------------------------------------+
*/
-/* $Id: php_xmlwriter.c,v 1.20.2.12.2.15.2.14 2009/05/25 16:09:27 pajoye Exp $ */
+/* $Id: php_xmlwriter.c,v 1.20.2.12.2.15.2.15 2009/05/26 08:10:49 pajoye Exp $ */
#ifdef HAVE_CONFIG_H
#include "config.h"
@@ -1781,6 +1781,9 @@
RETURN_FALSE;
}
+ /* TODO: Fix either the PHP stream or libxml APIs: it can then detect when a given
+ path is valid and not report out of memory error. Once it is done, remove the
+ directory check in _xmlwriter_get_valid_file_path */
#ifndef ZEND_ENGINE_2
ioctx = php_xmlwriter_streams_IO_open_write_wrapper(valid_file TSRMLS_CC);
if (ioctx == NULL) {