Re: cvs: php-src / README.PARAMETER_PARSING_API /win32/build config.w32 ZendEngine2 Zend.m4 zend_API.c zend_compile.c zend_execute.c
zend_execute_API.c zend_operators.c zend_operators.h zend_vm_def.h zend_vm_execute.h

Hi Antony, Lukas, ----- Original Message ----- From: "Lukas Kahwe Smith" Sent: Monday, June 08, 2009

On 08.06.2009, at 09:26, Antony Dovgal wrote:

On 05.06.2009 21:15, Matt Wilmas wrote:

ext/standard/tests/strings/chunk_split_variation2.phpt ext/standard/tests/strings/chunk_split_variation5.phpt ext/standard/tests/strings/chunk_split_variation8.phpt

It looks like these should also be failing with 5.2 on 64-bit?

Well, they don't.

Do you have the diffs to show? Thanks. Comment below...

I'll leave them as-is for now then... Some options: Skip them on 64-bit? variation2 could have a 64-bit version added. variation5/8 look like the same thing (and don't get why they reference Bug #42796). Their logic for the test value (PHP_INT_MAX * 3) is flawed anyway with the old (err, formerly new) double->long conversion method, but that could be changed to get the same result cross-platform...

Sounds like we have a BC issue?

Nah, just something isolated with these tests it seems. (All other tests are presumably fine.) The double->int conversion method on 64-bit is exactly the same as 5.2, so... Looking at those chunk_split() tests quickly again, variation2 is the same in 5.2 and 5.3 for anything related to dval->lval conversion. And the duplicate variation5/8, I do see now why the one iteration would fail on 64-bit (if that's the only part failing). However, on those 2 tests, I think it's *not possible* for it to pass with 5.2 on 64-bit (at the same iteration). No way, AFAICT. :-/

regards, Lukas Kahwe Smith mls@pooteeweet.org

- Matt