Re: svn: php/php-src/branches/PHP_5_3/Zend/ zend_ini.c

On 07/17/2009 03:48 AM, Stanislav Malyshev wrote:

stas Fri, 17 Jul 2009 00:48:59 +0000 URL: http://svn.php.net/viewvc?view=revision&revision=284218 Changed paths: U php/php-src/branches/PHP_5_3/Zend/zend_ini.c Log: fix memleak Modified: php/php-src/branches/PHP_5_3/Zend/zend_ini.c =================================================================== --- php/php-src/branches/PHP_5_3/Zend/zend_ini.c 2009-07-17 00:25:54 UTC (rev 284217) +++ php/php-src/branches/PHP_5_3/Zend/zend_ini.c 2009-07-17 00:48:59 UTC (rev 284218) @@ -315,8 +315,11 @@ } if (EG(modified_ini_directives)) { - zend_restore_ini_entry_cb(ini_entry, stage TSRMLS_CC); - zend_hash_del(EG(modified_ini_directives), name, name_length); + if(zend_restore_ini_entry_cb(ini_entry, stage TSRMLS_CC) == 0) { + zend_hash_del(EG(modified_ini_directives), name, name_length);

Again, you failed to follow the coding style in this file (and everywhere else..).

+ } else { + return FAILURE; + } } return SUCCESS;