Re: svn: php/php-src/trunk/ NEWS Zend/zend.c Zend/zend_dtrace.c
| From: | Stanislav Malyshev | Date: | Mon, 20 Jul 2009 01:41:47 +0000 |
| Subject: | Re: svn: php/php-src/trunk/ NEWS Zend/zend.c Zend/zend_dtrace.c | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-59637@lists.php.net to get a copy of this message | ||
Hi!
+ char dtrace_error_buffer[1024];
TSRMLS_FETCH();
/* Obtain relevant filename and lineno */
@@ -1581,6 +1591,12 @@
va_start(args, format);
+ if(DTRACE_ERROR_ENABLED()) {
+ vsprintf(dtrace_error_buffer, format, args);
+ }
This doesn't look good. I don't see a check anywhere that format doesn't run over 1024 chars.
--
Stanislav Malyshev, Zend Software Architect
stas@zend.com http://www.zend.com/
(408)253-8829 MSN: stas@zend.com