Re: svn: SVNROOT/ commit-bugs.php

Rasmus Lerdorf wrote:

rasmus                                   Tue, 21 Jul 2009 21:57:58 +0000

Revision: http://svn.php.net/viewvc?view=revision&revision=284564 Log: This fixes the duplicate bugs as seen in http://news.php.net/php.cvs/59633 in the version of PHP running on y1. /me ducks Changed paths:

    U   SVNROOT/commit-bugs.php

Modified: SVNROOT/commit-bugs.php =================================================================== --- SVNROOT/commit-bugs.php 2009-07-21 21:33:54 UTC (rev 284563) +++ SVNROOT/commit-bugs.php 2009-07-21 21:57:58 UTC (rev 284564) @@ -40,7 +40,7 @@ // ----------------------------------------------------------------------------------------------------------------------------- // Make an RPC call for each bug include __DIR__ . '/secret.inc'; -foreach ($bug_list as &$bug) { +foreach ($bug_list as $k=>$bug) {

     // Only do this for core PHP bugs
     if ($bug['project'] !== '') {
         continue;

@@ -81,14 +81,14 @@

     $result = curl_exec($ch);

     if ($result === FALSE) {
-        $bug['error'] = curl_error($ch);
+        $bug_list[$k]['error'] = curl_error($ch);
     } else {
         $bug_server_data = json_decode($result, TRUE);
         if (isset($bug_server_data['result']['status'])) {
-            $bug['status'] = $bug_server_data['result']['status']['status'];
-            $bug['short_desc'] = $bug_server_data['result']['status']['sdesc'];
+            $bug_list[$k]['status'] = $bug_server_data['result']['status']['status'];
+            $bug_list[$k]['short_desc'] = $bug_server_data['result']['status']['sdesc'];
         } else {
-            $bug['error'] = $bug_server_data['result']['error'];
+            $bug_list[$k]['error'] = $bug_server_data['result']['error'];
         }
     }
     curl_close($ch);

unset($bug); after the foreach should have fixed that..? --Jani