Re: svn: /php/php-src/trunk/sapi/nsapi/ nsapi.c

On 08/03/2009 01:36 PM, Uwe Schindler wrote:

Thanks Jani, I thought it is still optional to do this.

Semi-optional. Since we use svn, why not fully make use of the features it provides?

The question is, how to do that on Windows with TortoiseSVN using the GUI?

No idea..is it not possible? Use some other svn client? Or commit from command line, it's not that hard..? (no idea if that's possible in windows..I don't do clickety-click stuff) --Jani

We had a similar discussion on the Lucene-Java Mailinglist about updating the backwards-compatibility tests branch with one commit together with trunk. ----- Uwe Schindler thetaphi@php.net - http://www.php.net NSAPI SAPI developer Bremen, Germany

-----Original Message----- From: Jani Taskinen [mailto:jani@php.net] Sent: Monday, August 03, 2009 12:26 PM To: Uwe Schindler Cc: php-cvs@lists.php.net; gwynne@php.net Subject: Re: [PHP-CVS] svn: /php/php-src/trunk/sapi/nsapi/ nsapi.c Please use the "single-commit" way instead of doing multiple commits. Especially when you fix bugs..now there are 3 commit entries in that report. :D See also:

    http://wiki.php.net/vcs/svnfaq#sparse_directory_checkout_instructions

--Jani On 08/03/2009 01:12 PM, Uwe Schindler wrote:

thetaphi                                 Mon, 03 Aug 2009 10:12:30 +0000

Revision: http://svn.php.net/viewvc?view=revision&revision=286721 Log: Fix bug #46020: With Sun Java System Web Server 7.0 on HPUX, #define

HPUX

Bug: http://bugs.php.net/46020 (Assigned) With Sun Java System Web

Server 7.0 on HPUX, #define HPUX

Changed paths:

      U   php/php-src/trunk/sapi/nsapi/nsapi.c

Modified: php/php-src/trunk/sapi/nsapi/nsapi.c =================================================================== --- php/php-src/trunk/sapi/nsapi/nsapi.c 2009-08-03 09:48:53 UTC

(rev 286720)

+++ php/php-src/trunk/sapi/nsapi/nsapi.c 2009-08-03 10:12:30 UTC

(rev 286721)

@@ -57,6 +57,13 @@ #endif /* + * The manual define of HPUX is to fix bug #46020, nsapi.h needs this

to detect HPUX

+ */ +#ifdef __hpux +#define HPUX +#endif + +/*

    * NSAPI includes
    */

#include "nsapi.h"