Re: svn: /php/php-src/ branches/PHP_5_2/main/SAPI.c branches/PHP_5_3/main/SAPI.c trunk/main/SAPI.c

Antony Dovgal wrote:

On 17.08.2009 20:54, Jani Taskinen wrote:

jani                                     Mon, 17 Aug 2009 16:54:39 +0000

Revision: http://svn.php.net/viewvc?view=revision&revision=287422

Jani, you seem to be the last one to touch this stuff and _it seems_ that this patch causes memleaks in the following tests:

If removing the #if HAVE_ZLIB really causes memleaks, then those memleaks really existed prior the change as well. I would guess the real reason is somewhere else. --Jani

/local/qa/5_3_non-ZTS/ext/mbstring/tests/htmlent.phpt /local/qa/5_3_non-ZTS/ext/mbstring/tests/mb_output_handler_euc_jp.phpt /local/qa/5_3_non-ZTS/ext/mbstring/tests/mb_output_handler_pattern-01.phpt /local/qa/5_3_non-ZTS/ext/mbstring/tests/mb_output_handler_pattern-02.phpt /local/qa/5_3_non-ZTS/ext/mbstring/tests/mb_output_handler_pattern-03.phpt /local/qa/5_3_non-ZTS/ext/mbstring/tests/mb_output_handler_pattern-04.phpt /local/qa/5_3_non-ZTS/ext/mbstring/tests/mb_output_handler_pattern-05.phpt /local/qa/5_3_non-ZTS/ext/mbstring/tests/mb_output_handler_pattern-06.phpt /local/qa/5_3_non-ZTS/ext/mbstring/tests/mb_output_handler_pattern-07.phpt /local/qa/5_3_non-ZTS/ext/mbstring/tests/mb_output_handler_pattern-08.phpt /local/qa/5_3_non-ZTS/ext/mbstring/tests/mb_output_handler_pattern-09.phpt /local/qa/5_3_non-ZTS/ext/mbstring/tests/mb_output_handler_pattern-10.phpt /local/qa/5_3_non-ZTS/ext/mbstring/tests/mb_output_handler_pattern-11.phpt /local/qa/5_3_non-ZTS/ext/mbstring/tests/mb_output_handler_pattern-12.phpt /local/qa/5_3_non-ZTS/ext/mbstring/tests/mb_output_handler_runtime_ini_alteration-01.phpt /local/qa/5_3_non-ZTS/ext/mbstring/tests/mb_output_handler_runtime_ini_alteration-02.phpt /local/qa/5_3_non-ZTS/ext/mbstring/tests/mb_output_handler_shift_jis.phpt # cat /local/qa/5_3_ZTS/ext/mbstring/tests/mb_output_handler_pattern-12.diff 002+ [Fri Aug 21 22:47:30 2009] Script: '/local/qa/5_3_ZTS/ext/mbstring/tests/mb_output_handler_pattern-12.php' 003+ /local/qa/5_3_ZTS/main/output.c(228) : Freeing 0x01536C98 (32 bytes), script=/local/qa/5_3_ZTS/ext/mbstring/tests/mb_output_handler_pattern-12.php 004+ [Fri Aug 21 22:47:30 2009] Script: '/local/qa/5_3_ZTS/ext/mbstring/tests/mb_output_handler_pattern-12.php' 005+ /local/qa/5_3_ZTS/Zend/zend_execute_API.c(843) : Freeing 0x01538BA0 (32 bytes), script=/local/qa/5_3_ZTS/ext/mbstring/tests/mb_output_handler_pattern-12.php 006+ Last leak repeated 1 time 007+ [Fri Aug 21 22:47:30 2009] Script: '/local/qa/5_3_ZTS/ext/mbstring/tests/mb_output_handler_pattern-12.php' 008+ /local/qa/5_3_ZTS/main/output.c(229) : Freeing 0x0153A378 (10 bytes), script=/local/qa/5_3_ZTS/ext/mbstring/tests/mb_output_handler_pattern-12.php 009+ === Total 4 memory leaks detected ===