Re: svn: /php/php-src/trunk/ ext/standard/proc_open.c ext/zip/php_zip.c main/php_streams.h

hi Dmitry, > Modified: php/php-src/trunk/ext/zip/php_zip.c > =================================================================== > @@ -2411,16 +2411,16 @@>        } > >        ZIP_FROM_OBJECT(intern, this); > -       if (zval_files && (Z_TYPE_P(zval_files) != IS_NULL)) { > -               switch (Z_TYPE_P(zval_files)) { > +       if (zval_files && (Z_TYPE_PP(zval_files) != IS_NULL)) { > +               switch (Z_TYPE_PP(zval_files)) { >                        case IS_UNICODE: > -                               if (FAILURE == > php_stream_path_param_encode(&zval_files, &file, &file_len, REPORT_ERRORS, > FG(default_context))) { > +                               if (FAILURE == > php_stream_path_param_encode(zval_files, &file, &file_len, REPORT_ERRORS, > FG(default_context))) { >                                        RETURN_FALSE; >                                } Please merge these changes to in 5.3, 5.2 and pecl if necessary. For what I see while reading this code again is that the wrong macro is used as well in the other branches. Cheers, -- Pierre http://blog.thepimp.net | http://www.libgd.org