Re: svn: /php/php-src/ branches/PHP_5_2/NEWS branches/PHP_5_2/ext/simplexml/simplexml.c branches/PHP_5_3/NEWS
branches/PHP_5_3/ext/simplexml/simplexml.c trunk/ext/simplexml/simplexml.c
| From: | Pierre Joye | Date: | Thu, 08 Oct 2009 00:15:06 +0000 |
| Subject: | Re: svn: /php/php-src/ branches/PHP_5_2/NEWS branches/PHP_5_2/ext/simplexml/simplexml.c branches/PHP_5_3/NEWS branches/PHP_5_3/ext/simplexml/simplexml.c trunk/ext/simplexml/simplexml.c |
||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-60598@lists.php.net to get a copy of this message | ||
hi Ilia,
On Wed, Oct 7, 2009 at 2:46 PM, Ilia Alshanetsky <iliaa@php.net> wrote:
> iliaa Wed, 07 Oct 2009 12:46:29 +0000
>
> Revision:
> http://svn.php.net/viewvc?view=revision&revision=289279
>
> Log:
> Fixed bug #49800 (SimpleXML allow (un)serialize() calls without warning).
>
> # original patch by wmeler at wp-sa dot pl
>
> Bug: http://bugs.php.net/49800 (Open) SimpleXML allow
> serialize() calls without warning
Seriously this time, can you please at least try to compile before you
commit a patch? As I'm sure many of us have no problem to fix build
issues here and there (incl. for me), it became slowly a must for your
commits. Please try to do it from now on :)
simplexml.c
c:\php-sdk\snap_5_2\vc6\x86\php52\ext\simplexml\simplexml.c(2415) :
error C2065: 'zend_class_serialize_deny' : undeclared identifier
c:\php-sdk\snap_5_2\vc6\x86\php52\ext\simplexml\simplexml.c(2415) :
warning C4047: '=' : 'int (__cdecl *)(struct _zval_struct *,unsigned
char ** ,unsigned int *,struct _zend_serialize_data *)' differs in
levels of indirection
from 'int '
c:\php-sdk\snap_5_2\vc6\x86\php52\ext\simplexml\simplexml.c(2416) :
error C2065: 'zend_class_unserialize_deny' : undeclared identifier
c:\php-sdk\snap_5_2\vc6\x86\php52\ext\simplexml\simplexml.c(2416) :
warning C4047: '=' : 'int (__cdecl *)(struct _zval_struct ** ,struct
_zend_class_entry *,const unsigned char *,unsigned int ,struct
_zend_unserialize_data *)' differs in levels of indirection from 'int
'
Thanks for your work,
Cheers,
--
Pierre
http://blog.thepimp.net | http://www.libgd.org