Re: svn: /php/php-src/branches/PHP_5_3/ext/phar/tests/ phar_buildfromdirectory6.phpt
| From: | Greg Beaver | Date: | Sat, 21 Nov 2009 06:32:04 +0000 |
| Subject: | Re: svn: /php/php-src/branches/PHP_5_3/ext/phar/tests/ phar_buildfromdirectory6.phpt | ||
| References: | 1 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-60963@lists.php.net to get a copy of this message | ||
Brian Shire wrote:
> shire Sat, 21 Nov 2009 05:40:16 +0000
>
> Revision: 0zï²O_`¶ô+½Ha}
> http://svn.php.net/viewvc?view=revision&revision=291108
>
> Log:
> MFH: Fix phar regex test when '.php' is part of the path, instead be more specific
> with '.php$' regex.
>
> Changed paths:
> U php/php-src/branches/PHP_5_3/ext/phar/tests/phar_buildfromdirectory6.phpt
>
> Modified: php/php-src/branches/PHP_5_3/ext/phar/tests/phar_buildfromdirectory6.phpt
> ===================================================================
> --- php/php-src/branches/PHP_5_3/ext/phar/tests/phar_buildfromdirectory6.phpt 2009-11-21
> 05:38:58 UTC (rev 291107)
> +++ php/php-src/branches/PHP_5_3/ext/phar/tests/phar_buildfromdirectory6.phpt 2009-11-21
> 05:40:16 UTC (rev 291108)
> @@ -15,7 +15,7 @@
>
> try {
> $phar = new Phar(dirname(__FILE__) . '/buildfromdirectory.phar');
> - var_dump($phar->buildFromDirectory(dirname(__FILE__) . '/testdir',
> '/\.php/'));
> + var_dump($phar->buildFromDirectory(dirname(__FILE__) . '/testdir',
> '/\.php$/'));
> } catch (Exception $e) {
> var_dump(get_class($e));
> echo $e->getMessage() . "\n";
Hi,
Thanks for this fix, do you mind merging to pecl/phar/trunk?
Thanks,
Greg