Re: svn: /php/php-src/trunk/ext/hash/ config.m4 hash.c hash_fnv.c php_hash.h php_hash_fnv.h tests/fnv132.phpt tests/fnv164.phpt

From: Date: Tue, 23 Mar 2010 23:06:11 +0000
Subject: Re: svn: /php/php-src/trunk/ext/hash/ config.m4 hash.c hash_fnv.c php_hash.h php_hash_fnv.h tests/fnv132.phpt tests/fnv164.phpt
References: 1  Groups: php.cvs 
Request: Send a blank email to php-cvs+get-62106@lists.php.net to get a copy of this message
Heya, + {"FNV1a32", "fnv1a32", 30}, + {"FNV1a64", "fnv1a64", 32}, I think those two should be FNV1A32/64, since they seem to be used to define MHASH_* constants, and constants with lowercased letter are really non-standard. Other than that, as mentionned on irc, thanks for the patch, and I'd be interested if you could run a hash benchmark [1] on it, if you have it compiled, to see how it compares to other fast algos. Cheers, Jordi [1] http://www.php.net/manual/en/function.hash.php#89574

« previous php.cvs (#62106) next »