Re: svn: /php/php-src/ branches/PHP_5_3/ext/mysql/tests/connect.inc branches/PHP_5_3/ext/mysqli/tests/connect.inc
branches/PHP_5_3/ext/mysqli/tests/mysqli_poll_kill.phpt branches/PHP_5_3/ext/mysqlnd/mysqlnd.c branches/PHP_5_3/ext/mysqlnd/my

On Fri, Mar 26, 2010 at 17:58, Andrey Hristov <andrey@php.net> wrote: > andrey                                   Fri, 26 Mar 2010 16:58:25 +0000 > > Revision: o > Â1ç_õpKU¾«m‚http://svn.php.net/viewvc?view=revision&revision=296885 > > Log: > Fix tests that fail when the MySQL's socket file is not /tmp/mysql.sock > as it is in when compiled from source and the default for mysqlnd. > SuSE for example uses /var/run/mysql/mysql.sock . Also, sql.safe_mode > (ext/mysql and ingres) needs the socket. > Fix possible crashes in mysqlnd. When packets are shorter, functions should > return error. > Modified: php/php-src/trunk/ext/mysqlnd/mysqlnd.c =================================================================== --- php/php-src/trunk/ext/mysqlnd/mysqlnd.c 2010-03-26 16:55:03 UTC (rev 296884) +++ php/php-src/trunk/ext/mysqlnd/mysqlnd.c 2010-03-26 16:58:25 UTC (rev 296885) @@ -516,20 +516,24 @@ if (!host || !host[0]) { host = "localhost"; } - if (!user || !user[0]) { - user = php_get_current_user(); + if (!user) { + DBG_INF_FMT("no user given, using empty string"); + user = ""; } Isn't this a backwards compatibility break? That however doesn't seem to be documented, so I guess not many relied on it.. but it may be worth mentioning? -Hannes