Re: svn: /php/php-src/trunk/ NEWS ext/standard/datetime.c main/main.c main/php_globals.h php.ini-development php.ini-production
| From: | Johannes Schlüter | Date: | Thu, 15 Apr 2010 11:48:40 +0000 |
| Subject: | Re: svn: /php/php-src/trunk/ NEWS ext/standard/datetime.c main/main.c main/php_globals.h php.ini-development php.ini-production | ||
| References: | 1 2 | Groups: | php.cvs |
| Request: | Send a blank email to php-cvs+get-62263@lists.php.net to get a copy of this message | ||
On Thu, 2010-04-15 at 12:04 +0100, Derick Rethans wrote:
> On Mon, 12 Apr 2010, Kalle Sommer Nielsen wrote:
>
> > Modified: php/php-src/trunk/main/php_globals.h
> > ===================================================================
> > --- php/php-src/trunk/main/php_globals.h 2010-04-12 07:01:46 UTC (rev 297863)
> > +++ php/php-src/trunk/main/php_globals.h 2010-04-12 07:34:30 UTC (rev 297864)
> > @@ -127,8 +127,6 @@
> > zend_bool register_argc_argv;
> > zend_bool auto_globals_jit;
> >
> > - zend_bool y2k_compliance;
> > -
> > char *docref_root;
> > char *docref_ext;
>
> This breaks the ABIs, so please update the API numbers as well!
Shouldn't we then also update the middle version number, so
PHP_VERSION_ID can be used for readable #ifdefs?
(I suggested that before ...)
johannes