Re: svn: /php/php-src/branches/PHP_5_3/ext/mysqlnd/ mysqlnd_result.c

From: Date: Wed, 25 Aug 2010 16:02:53 +0000
Subject: Re: svn: /php/php-src/branches/PHP_5_3/ext/mysqlnd/ mysqlnd_result.c
References: 1 2  Groups: php.cvs 
Request: Send a blank email to php-cvs+get-63371@lists.php.net to get a copy of this message
Adam Harvey wrote:
On 25 August 2010 23:06, Andrey Hristov <andrey@php.net> wrote:
+ Â Â Â Â Â Â Â php_error_docref(NULL TSRMLS_CC, E_ERROR, "magic_quotes_runtime are not supported by mysqlnd. They were deprecated in PHP 5.3 ");
Is E_ERROR the appropriate level here? This could break code between 5.3 point releases. OK, you could argue that code is broken already, but I think I'd be more comfortable with a warning. Adam Users might run with warnings disabled, but if the application doesn't run at all - due to E_ERROR, then they will definitely be notified and will take measures. According to Johannes this deficiency of current mysqlnd can lead to security problems.
Andrey

« previous php.cvs (#63371) next »