Re: svn: /php/php-src/trunk/ UPGRADING.INTERNALS ext/standard/basic_functions.c ext/standard/basic_funct ions.h main/php_streams.h
main/streams/memory.c m ain/streams/streams.c
| From: | Gustavo Lopes | Date: | Mon, 15 Nov 2010 16:49:54 +0000 |
| Subject: | Re: svn: /php/php-src/trunk/ UPGRADING.INTERNALS ext/standard/basic_functions.c ext/standard/basic_funct ions.h main/php_streams.h main/streams/memory.c m ain/streams/streams.c |
||
| References: | 1 2 | Groups: | php.cvs php.internals |
| Request: | Send a blank email to php-cvs+get-63839@lists.php.net to get a copy of this message | ||
On Mon, 15 Nov 2010 08:25:44 +0100, Kalle Sommer Nielsen <kalle@php.net>
wrote:
> Hi
>
> 2010/11/15 Gustavo André dos Santos Lopes <cataphract@php.net>:
>> cataphract Mon, 15 Nov 2010 03:05:32
+0000
>>
>> Revision:
>> http://svn.php.net/viewvc?view=revision&revision=305346
>>
>> Log:
>> - Added leak_variable() function.
>
> Why do we need a leak_variable() function in a regular build unlike
> leak() and crash() which are defined in zend_builtin_functions.c in
> debug mode only or did I miss something here?
It's only in the debug build. In any case, it would be indeed better among
leak() and crash(). The attached patch moves it there, but it will have to
be someone else commiting it.
--
Gustavo Lopes
Attachment: [text/x-diff] leak_variable.txt
Attachment: [text/x-diff] leak_variable.txt