Re: svn: /php/php-src/branches/PHP_5_3/ext/date/ php_date.c php_date.h

On Thu, 18 Nov 2010, Johannes Schlüter wrote: > On Sat, 2010-11-13 at 16:31 +0000, Derick Rethans wrote: > > Changed paths: > > U php/php-src/branches/PHP_5_3/ext/date/php_date.c > > U php/php-src/branches/PHP_5_3/ext/date/php_date.h > > > -PHPAPI int php_idate(char format, time_t ts, int localtime) > > +PHPAPI int php_idate(char format, time_t ts, int localtime TSRMLS_DC) > > This breaks the ABI in a point release. Ah right, I've fixed that. So much for keeping 5.3 and trunk in sync :-) > > /* Backwards compability wrapper */ > > PHPAPI signed long php_parse_date(char *string, signed long *now); > > PHPAPI void php_mktime(INTERNAL_FUNCTION_PARAMETERS, int gmt); > > -PHPAPI int php_idate(char format, time_t ts, int localtime); > > +PHPAPI int php_idate(char format, time_t ts, int localtime > > TSRMLS_DC); > > #if HAVE_STRFTIME > > #define _php_strftime php_strftime > > PHPAPI void php_strftime(INTERNAL_FUNCTION_PARAMETERS, int gm); > > Ah, I remember the discussion. How can it be a "Backwards compability > wrapper" if it isn't backwards compatible in its signature? Or does the > comment apply only to php_parse_date()? > Can we use TSRMLS_FETCH() in 5_3 and move this away from the comment in > trunk? The "Backwards compability wrapper" was there already. The signature change should not be. So the comment should stay. regards, Derick -- http://derickrethans.nl | http://xdebug.org Like Xdebug? Consider a donation: http://xdebug.org/donate.php twitter: @derickr and @xdebug