Re: svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/sapi/fpm/fpm/fpm.h branches/PHP_5_3/sapi/fpm/fpm/fpm_conf.c
branches/PHP_5_3/sapi/fpm/fpm/fpm_main.c branches/PHP_5_3/sapi/fpm/php-fpm.8.in trunk/sapi/fpm/fpm/fpm.h trunk/sapi/fp
| From: | Jérôme Loyet | Date: | Thu, 18 Nov 2010 11:31:31 +0000 |
| Subject: | Re: svn: /php/php-src/ branches/PHP_5_3/NEWS branches/PHP_5_3/sapi/fpm/fpm/fpm.h branches/PHP_5_3/sapi/fpm/fpm/fpm_conf.c branches/PHP_5_3/sapi/fpm/fpm/fpm_main.c branches/PHP_5_3/sapi/fpm/php-fpm.8.in trunk/sapi/fpm/fpm/fpm.h trunk/sapi/fp |
||
| Groups: | php.cvs | ||
| Request: | Send a blank email to php-cvs+get-63892@lists.php.net to get a copy of this message | ||
2010/11/18 Johannes Schlüter <johannes@schlueters.de>:
> Hi,
>
> no big issue but a quick reminder:
Yes I know there is some part of the code which does not respect the
standard. I've already started to pass all this and correct, work in
progress.
>
> On Thu, 2010-11-11 at 23:27 +0000, Jérôme Loyet wrote:
>> + if (free) efree(filename);
>
> CODING_STANDARDS says:
>
> Syntax and indentation
> ----------------------
> [...]
> 3. Be generous with whitespace and braces. Keep one empty line between the
> variable declaration section and the statements in a block, as well as
> between logical statement groups in a block. Maintain at least one empty
> line between two functions, preferably two. Always prefer::
>
> if (foo) {
> bar;
> }
>
> to:
>
> if(foo)bar;
>
> johannes
>
>
>